Skip to content

feat: add AWS DevOps Agent regions and send the API version - #925

Merged
cchu-ld merged 1 commit into
mainfrom
cchu/aws-devops-0-regions-api
Oct 20, 2026
Merged

cchu-ld merged 1 commit into
mainfrom
cchu/aws-devops-0-regions-api

Conversation

@cchu-ld

@cchu-ld cchu-ld commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

None.

Describe the solution you've provided

  • Problem: setup rejected us-east-2, ap-northeast-2, eu-west-3, and eu-north-1, but the AWS DevOps Agent is available in those regions.
    • Solution: SupportedRegions has 15 regions, up from 11.
  • Problem: The token check sent no LD-API-Version header. Thus the response depended on the default API version of the token.
    • Solution: The token check sends LD-API-Version: 20240415. internal/resources exports APIVersion, so both use one constant. The rename from apiVersion exports the constant, because Go hides a lowercase name from other packages.

Describe alternatives you've considered

None.

Additional context

Testing: go test ./... and golangci-lint pass on this branch.

🤖 Generated with Claude Code


Note

Overview
AWS DevOps Agent support expands from 11 to 15 regions by adding us-east-2, ap-northeast-2, eu-west-3, and eu-north-1 in SupportedRegions, so ldcli aws-devops-agent setup no longer rejects those control-plane regions. The README region list matches.

LaunchDarkly token validation before MCP registration now sends LD-API-Version: 20240415 on the caller-identity check, so validation does not depend on each token’s default API version. internal/resources exports APIVersion (formerly unexported apiVersion) for shared use with the REST client.

Tests cover the new allowlist, near-miss rejections, the full region list, and the API version header.

Reviewed by Cursor Bugbot for commit e6239a6. Bugbot is set up for automated code reviews on this repo. Configure here.

Setup accepts us-east-2, ap-northeast-2, eu-west-3, and eu-north-1.

The token check sends LD-API-Version 20240415, the same version that
the resources client sends. internal/resources exports APIVersion, so
both use one constant.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cchu-ld
cchu-ld added this pull request to stack #926 October 20, 2026 18:38
@cchu-ld
cchu-ld marked this pull request as ready for review October 20, 2026 18:40
@cchu-ld
cchu-ld requested a review from a team as a code owner October 20, 2026 18:40
@cchu-ld
cchu-ld requested review from a team and davidbrackbill and removed request for a team October 20, 2026 18:40
@cchu-ld
cchu-ld merged commit bbbb33c into main Oct 20, 2026
12 checks passed
@cchu-ld
cchu-ld deleted the cchu/aws-devops-0-regions-api branch October 20, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants